[Mesa-dev] [PATCH 2/2] i965: Don't maintain programs for ff state when there is no ff

[Eric Anholt]

Ian Romanick <idr at freedesktop.org> writes:

> On 11/26/2012 11:19 PM, Eric Anholt wrote:
>> Ian Romanick <idr at freedesktop.org> writes:
>>
>>> From: Ian Romanick <ian.d.romanick at intel.com>
>>>
>>> NOTE: This is a candidate for the 9.0 branch.
>>>
>>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>>
>> Has this actually been tested for the undefined-but-not-crash cases?
>> I'm guessing not -- we've got lots of assumptions that a pair of actual
>> shaders exist in our driver, and I think this change means we'll deref
>> NULL pointers.
>
> That's a fair point.  These patches have been sitting in the gles3 
> branch for several months.  There was no change in piglit, but that 
> probably just means we don't have a test case for those situations.  Do 
> you have some suggestions for test cases you think might cause problems? 
>   I can code some up...

Well, just rendering without a vs or fs and making sure we run to
completion seems like easy tests.  The real interesting one would be on
a core context, rendering with a vs, tfb, and raster discard but no fs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121127/794b3516/attachment-0001.pgp>