[Mesa-dev] [PATCH 3/3] i965/gen4-5: Fix segfaults with stencil-only depth/stencil setups.

[Kenneth Graunke]

On 11/27/2012 12:12 AM, Eric Anholt wrote:
> Fixes a ton of piglit regressions since the depthstencil fixes for gen6+.
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57309
> ---
>   src/mesa/drivers/dri/i965/brw_misc_state.c |    4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c
> index 9c07be2..b0a1918 100644
> --- a/src/mesa/drivers/dri/i965/brw_misc_state.c
> +++ b/src/mesa/drivers/dri/i965/brw_misc_state.c
> @@ -554,8 +554,10 @@ static void emit_depthbuffer(struct brw_context *brw)
>      /* If there's a packed depth/stencil bound to stencil only, we need to
>       * emit the packed depth/stencil buffer packet.
>       */
> -   if (!depth_irb && stencil_irb && !separate_stencil)
> +   if (!depth_irb && stencil_irb && !separate_stencil) {
>         depth_irb = stencil_irb;
> +      depth_mt = stencil_mt;
> +   }
>
>      if (intel->gen >= 6)
>         len = 7;

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I still think that splitting out gen4-5 from gen6-7 here would be highly 
beneficial.  The paths are significantly different and we keep breaking 
gen4-5.