[Mesa-dev] [PATCH 8/8] RFC: llvmpipe: Fix format manipulation for big-endian

Adhemerval Zanella azanella at linux.vnet.ibm.com
Wed Nov 28 04:35:15 PST 2012


On 11/22/2012 07:37 PM, Roland Scheidegger wrote:
> Am 22.11.2012 21:35, schrieb Adhemerval Zanella:
>> This patch fixes various format manipulation for big-endian
>> architectures. Basically it works on two fronts: 1) by adjusting
>> some algorithms that do shifts/mask on vector or integers and 2)
>> by correct loading floating-point in memory.
>>
>> Also, the 'lp_bld_format_aos_array.c' approach to load vectors
>> is naive (it loads element per element). I plan work on this to
>> use a better approach to load and permute the vector instead.
>>
>> Any tips, advices, comments?
> I think the last part of the patch should be separate (as it doesn't
> look related to llvmpipe at all) but otherwise looks good (though
> slightly ugly but that's expected).
>
> Roland
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Thanks for the review Roland. Although at first sight
'src/gallium/auxiliary/util/u_format_other.c' seems to be related to llvmpipe
I noted some lp_test_format formats calls its functions (that's why I have
spotted the bswap issues in first place).



More information about the mesa-dev mailing list