[Mesa-dev] [PATCH 2/3] glcpp: Support #elif(expression) with no intervening space.

Matt Turner mattst88 at gmail.com
Thu Nov 29 10:35:25 PST 2012


On Wed, Nov 28, 2012 at 9:37 PM, Carl Worth <cworth at cworth.org> wrote:
> Carl Worth <cworth at cworth.org> writes:
>> (For the subsequent __LINE__ and __FILE__ I think we can do better, and
>> I'll attempt that next.)
>
> I've coded this up, and I think the support is quite reasonable.
>
> After I coded it, I simplified some repeated code a bit, and then I
> started exploring some token-pasting code which was inspired by my new
> test case.
>
> Ken, you had me convinced that I had forgotten to fix that old "a ## b
> ## c" token-pasting bug. The truth was that I had forgotten that I had
> actually fixed that some time ago. But I did find some other
> token-pasting bugs, (pasting the expansion of an internally-defined
> macro which expands to an integer was failing).
>
> So expect a series of 7 patches to address these issues in the
> preprocessor.
>
> I didn't see any of the piglit tests that I run on a regular basis
> changed by the series. (I saw the fs-bool-less-compare-true test flip
> From pass to fail, but I'm assuming that's just another unreliable
> test.)
>
> Matt, you said you were originally doing this to address some es3conform
> tests. Can you test this series on those, please?

Yes, your patch series also fixes the es3conform tests. :)


More information about the mesa-dev mailing list