[Mesa-dev] [PATCH] svga: remove pointless assert on unsigned >= 0

Brian Paul brianp at vmware.com
Fri Nov 30 07:10:42 PST 2012


On 11/30/2012 03:05 AM, Dave Airlie wrote:
> all unsigneds are>= 0 :-)
>
> There may be an argument for leaving this in, in case someone
> changes min_lod to an integer, so feel free to apply or drop.
>
> Signed-off-by: Dave Airlie<airlied at redhat.com>
> ---
>   src/gallium/drivers/svga/svga_sampler_view.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/gallium/drivers/svga/svga_sampler_view.c b/src/gallium/drivers/svga/svga_sampler_view.c
> index 281a44f..efbc138 100644
> --- a/src/gallium/drivers/svga/svga_sampler_view.c
> +++ b/src/gallium/drivers/svga/svga_sampler_view.c
> @@ -65,7 +65,6 @@ svga_get_tex_sampler_view(struct pipe_context *pipe,
>      boolean view = TRUE;
>
>      assert(pt);
> -   assert(min_lod>= 0);
>      assert(min_lod<= max_lod);
>      assert(max_lod<= pt->last_level);
>

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list