[Mesa-dev] [PATCH 1/2] glsl: initialise killed_all field.

Brian Paul brianp at vmware.com
Fri Nov 30 07:15:11 PST 2012


On 11/30/2012 03:25 AM, Dave Airlie wrote:
> coverity pointed out this field was being used uninitialised.
>
> Signed-off-by: Dave Airlie<airlied at redhat.com>
> ---
>   src/glsl/opt_constant_propagation.cpp | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/glsl/opt_constant_propagation.cpp b/src/glsl/opt_constant_propagation.cpp
> index c5ae36b..a038119 100644
> --- a/src/glsl/opt_constant_propagation.cpp
> +++ b/src/glsl/opt_constant_propagation.cpp
> @@ -92,6 +92,7 @@ public:
>      ir_constant_propagation_visitor()
>      {
>         progress = false;
> +      killed_all = false;
>         mem_ctx = ralloc_context(0);
>         this->acp = new(mem_ctx) exec_list;
>         this->kills = new(mem_ctx) exec_list;

Both LGTM.  Candidates for stable branches?

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list