[Mesa-dev] [PATCH 26/26] glsl: Support unsigned integer constants in layout qualifiers.

Ian Romanick idr at freedesktop.org
Fri Nov 30 14:52:56 PST 2012


On 11/30/2012 02:49 PM, Eric Anholt wrote:
> Ian Romanick <idr at freedesktop.org> writes:
>
>> From: Kenneth Graunke <kenneth at whitecape.org>
>>
>> Fixes es3conform's explicit_attrib_location_integer_constants.
>>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>> Reviewed-by: Eric Anholt <eric at anholt.net>
>> ---
>>   src/glsl/glsl_parser.yy | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy
>> index f123368..d849466 100644
>> --- a/src/glsl/glsl_parser.yy
>> +++ b/src/glsl/glsl_parser.yy
>> @@ -1088,6 +1088,7 @@ layout_qualifier_id_list:
>>   integer_constant:
>>   	INTCONSTANT { $$ = $1; }
>>   	| UINTCONSTANT { $$ = $1; }
>> +	;
>
> this looks like rebase leftovers that could just be dropped.

Isn't the ; necessary?  Every other rule in the grammar has it.



More information about the mesa-dev mailing list