[Mesa-dev] [PATCH v2 1/1] intel: print performance debug messages to `logcat' on Android.

[Kenneth Graunke]

On 10/01/2012 02:35 PM, Eric Anholt wrote:
> Oliver McFadden <oliver.mcfadden at linux.intel.com> writes:
>> diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
>> index 25334da..7eb2706 100644
>> --- a/src/mesa/drivers/dri/intel/intel_context.c
>> +++ b/src/mesa/drivers/dri/intel/intel_context.c
>> @@ -744,6 +744,11 @@ intelInitContext(struct intel_context *intel,
>>     intelInitExtensions(ctx);
>>  
>>     INTEL_DEBUG = driParseDebugString(getenv("INTEL_DEBUG"), debug_control);
>> +
>> +#ifdef HAVE_ANDROID_PLATFORM
>> +   INTEL_DEBUG |= DEBUG_PERF;
>> +#endif /* HAVE_ANDROID_PLATFORM */
>> +
>>     if (INTEL_DEBUG & DEBUG_BUFMGR)
>>        dri_bufmgr_set_debug(intel->bufmgr, true);
> 
> I don't see why the driver should be logging debug messages by default.
> You want to be able to actually ship this driver for non-developers.

At least normally, this causes a _ton_ of spew which can actually
introduce significant amounts of printf overhead.