[Mesa-dev] [Bug 55445] Torchlight: crash due to texture error

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55445

--- Comment #7 from Roland Scheidegger <sroland at vmware.com> ---
(In reply to comment #6)
> - Mipmap level 2 is 50x16 pixels, but 50 is not a multiple of 4.
>   mesa/main/teximage.c has specific code to return GL_INVALID_OPERATION if
>   given dimensions that aren't a multiple of the compression algorithm's
>   block-size, and the error message it includes is exactly the one seen if
> you
>   start Torchlight with MESA_DEBUG=1 set. This is also consistent with the
> Ogre
>   error that mentions mipmap 2.
This looks like a bug in mesa to me. There is no such restriction in neither
ARB_texture_compression nor EXT_texture_compression_s3tc. This restriction only
applies to [Compressed]TexSubImage calls not the [Compressed]TexImage calls.
Among others certainly because otherwise non-square mipmaps would always fail
at some point.
So I believe the right fix would be to simply drop that test (but don't drop it
from the subimage paths) - silently rounding up should not be necessary, things
like expectedSize calculations should do the right thing already.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121002/5154d732/attachment.html>