[Mesa-dev] broken tinderbox - AC_CHECK_FUNC nested in AC_CHECK_DECLS for signbit

[Matt Turner]

On Tue, Oct 2, 2012 at 10:48 PM, Dave Airlie <airlied at gmail.com> wrote:
> On Wed, Oct 3, 2012 at 3:45 PM, Dave Airlie <airlied at gmail.com> wrote:
>> On Wed, Oct 3, 2012 at 3:29 PM, Matt Turner <mattst88 at gmail.com> wrote:
>>> On Tue, Oct 2, 2012 at 8:02 PM, Dave Airlie <airlied at gmail.com> wrote:
>>>> Hi guys,
>>>>
>>>> Tinderbox is red due to mesa failing to build, investigating seems to
>>>> be the signbit change.
>>>>
>>>> The nesting of the AC_CHECK_FUNC inside the AC_CHECK_DECLS seems to
>>>> defeat autoconf 2.63 that we ship in RHEL6.
>>>>
>>>> removing the nesting lets it configure here, but hopefully someone has
>>>> a nicer idea.
>>>>
>>>> Dave.
>>>
>>> Brian added a signbit macro in the case that it doesn't exist, and
>>> then removed the check:
>>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=24a8e0c3da65019073f89cb7248916a692707db6
>>>
>>> So, problem solved.
>>>
>>> I don't know why the nesting wouldn't work though. I'm curious if
>>> putting brackets around AC_CHECK_FUNC(...) solves it?
>>
>> yeah sticking [] around it fixes it alright, which makes sense if you
>> can speak autoelvish.
>
> Except you brought it back in a rebase or mismerge:
>
> 7da12426f7682ffc44ae40e31d1b5712521fbb70
> build: Use AX_PTHREAD to detect pthreads
>
> Fail pick or rebase.
>
> Dave.

Oh! Whoops. I'll remove that.