[Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

Oliver McFadden oliver.mcfadden at linux.intel.com
Wed Oct 3 01:37:33 PDT 2012

On Tue, Oct 02, 2012 at 06:47:49PM -0700, Kenneth Graunke wrote:
> On 10/02/2012 04:00 AM, Oliver McFadden wrote:
> > This reverts commit 85cd30406ff8414bc6ac6de1064d059a4c564160.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55523
> > Signed-off-by: Oliver McFadden <oliver.mcfadden at linux.intel.com>
> > CC: Kenneth Graunke <kenneth at whitecape.org>
> > ---
> >  src/mesa/drivers/dri/i965/gen6_clip_state.c     |    1 -
> >  src/mesa/drivers/dri/i965/gen6_viewport_state.c |   24 +++++++++-------------
> >  2 files changed, 10 insertions(+), 15 deletions(-)
> Oliver,
> I'm fine with reverting these patches on the 9.0 branch...especially
> given how close we are to a release.  I'd like to leave them on master
> for a little while and do some investigation.  If we can't solve it, we
> can revert it...but if it ends up being something easy, I'd rather just
> fix it...

Okay.  I am unfamiliar with the process for applying patches onto the
release branches...  May I simply push the revert patches there, with
your Reviewed-by (which I assume you have given implicitly,) or must I
involve Brian?

> Since I can't reproduce this yet, I left a comment on the bug with an
> experiment you might want to try.

Yes I saw that this morning.  I will try to run the test now.  I can
provide an APItrace dump however it will be a few hundred megabytes; I
can host it on my server or on people.freedesktop.org.

I will reply to the bug once this is done, and after checking your

Oliver McFadden.

More information about the mesa-dev mailing list