[Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

[Oliver McFadden]

On Wed, Oct 03, 2012 at 11:53:55AM +0200, Andreas Boll wrote:
> 2012/10/3 Oliver McFadden <oliver.mcfadden at linux.intel.com>:
> > On Wed, Oct 03, 2012 at 11:37:33AM +0300, Oliver McFadden wrote:
> >> On Tue, Oct 02, 2012 at 06:47:49PM -0700, Kenneth Graunke wrote:
> >> > On 10/02/2012 04:00 AM, Oliver McFadden wrote:
> >> > > This reverts commit 85cd30406ff8414bc6ac6de1064d059a4c564160.
> >> > >
> >> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55523
> >> > > Signed-off-by: Oliver McFadden <oliver.mcfadden at linux.intel.com>
> >> > > CC: Kenneth Graunke <kenneth at whitecape.org>
> >> > > ---
> >> > >  src/mesa/drivers/dri/i965/gen6_clip_state.c     |    1 -
> >> > >  src/mesa/drivers/dri/i965/gen6_viewport_state.c |   24 +++++++++-------------
> >> > >  2 files changed, 10 insertions(+), 15 deletions(-)
> >> >
> >> > Oliver,
> >> >
> >> > I'm fine with reverting these patches on the 9.0 branch...especially
> >> > given how close we are to a release.  I'd like to leave them on master
> >> > for a little while and do some investigation.  If we can't solve it, we
> >> > can revert it...but if it ends up being something easy, I'd rather just
> >> > fix it...
> >>
> >> Okay.  I am unfamiliar with the process for applying patches onto the
> >> release branches...  May I simply push the revert patches there, with
> >> your Reviewed-by (which I assume you have given implicitly,) or must I
> >> involve Brian?
> >
> > I'm going to CC Brian into this discussion because these revert patches
> > really should be applied to both the 8.0 and 9.0 branches.  Ideally
> > before 9.0 is released, and before the next 8.x release.
> >
> 
> I can't find these two commits in the 8.0 branch.
> Only 9.0 and master are affected.

Yes, you're right; my mistake.

> You can go ahead and push the revert to 9.0, since Kenneth's
> reviewed-by should be enough.

Okay, I will push the patches momentarily.

> 
> Andreas.
> 
> > 7.11 branch is safe because it's before the introduction of these two
> > commits.
> >
> > Ken, may I add your Reviewed-by for these reverts as applied to the
> > stable branches?  I will wait before pushing to the master branch in
> > case you're able to come up with a solution for the guard-band clipping.
> >
> > --
> > Oliver McFadden.
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev

-- 
Oliver McFadden.