[Mesa-dev] [PATCH] mesa: don't enable glVertexPointer() when using API_OPENGLES2.

[Oliver McFadden]

On Wed, Oct 03, 2012 at 02:47:48PM -0700, Paul Berry wrote:
> This function is only present in GLES1 and in the OpenGL compatibility
> profile.
> 
> Fixes the following "make check" failure:
> 
>     [----------] 1 test from DispatchSanity_test
>     [ RUN      ] DispatchSanity_test.GLES2
>     Mesa warning: couldn't open libtxc_dxtn.so, software DXTn
>     compression/decompression unavailable
>     dispatch_sanity.cpp:122: Failure
>     Value of: table[i]
>        Actual: 0x4de54e
>     Expected: (_glapi_proc) _mesa_generic_nop
>     Which is: 0x41af72
>     i = 321
>     [  FAILED  ] DispatchSanity_test.GLES2 (4 ms)
>     [----------] 1 test from DispatchSanity_test (4 ms total)

Reviewed-by: Oliver McFadden <oliver.mcfadden at linux.intel.com>
Tested-by: Oliver McFadden <oliver.mcfadden at linux.intel.com>

> ---

You should really signoff your patches; for example:
git commit -a -s

Paul, can you commit this yourself, or would you like me to push it on
your behalf?

>  src/mesa/main/api_exec.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_exec.c
> index ddf7c7f..f42da94 100644
> --- a/src/mesa/main/api_exec.c
> +++ b/src/mesa/main/api_exec.c
> @@ -334,10 +334,8 @@ _mesa_create_exec_table(struct gl_context *ctx)
>     if (ctx->API != API_OPENGL_CORE && ctx->API != API_OPENGLES2) {
>        SET_NormalPointer(exec, _mesa_NormalPointer);
>        SET_PrioritizeTextures(exec, _mesa_PrioritizeTextures);
>        SET_TexCoordPointer(exec, _mesa_TexCoordPointer);
> -   }
> -   if (ctx->API != API_OPENGL_CORE) {
>        SET_VertexPointer(exec, _mesa_VertexPointer);
>     }
>  #endif
>  
> -- 
> 1.7.12.1
> 

-- 
Oliver McFadden.