[Mesa-dev] Mesa (master): configure.ac: Don't duplicate CFLAGS

[Stéphane Marchesin]

Hi Matt,

This patch breaks the build for me on one of my machines (Fedora 15):

gmake[3]: Entering directory `/home/marcheu/mesa/src/glsl/glcpp'
  LEX    glcpp-lex.c
  YACC   glcpp-parse.c
  CXX    glsl_lexer.lo
updating glcpp-parse.h
updating glcpp-parse.output
gmake  all-am
gmake[4]: Entering directory `/home/marcheu/mesa/src/glsl/glcpp'
  CC     glcpp-lex.lo
  CC     glcpp-parse.lo
  CC     pp.lo
  CC     ralloc.o
  CC     hash_table.o
  CC     glcpp.o
  CCLD   libglcpp.la
  CCLD   glcpp
ralloc.o: file not recognized: File truncated
collect2: ld returned 1 exit status

Any idea what's going on? The file ralloc.o is empty. Readding those
two lines fixes it.

Stéphane


On Wed, Aug 1, 2012 at 10:11 AM, Matt Turner
<mattst88 at kemper.freedesktop.org> wrote:
> Module: Mesa
> Branch: master
> Commit: 33ae29c93b8f70a86dcedc495dd658a5d5679db3
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=33ae29c93b8f70a86dcedc495dd658a5d5679db3
>
> Author: Matt Turner <mattst88 at gmail.com>
> Date:   Wed Aug  1 08:38:35 2012 -0700
>
> configure.ac: Don't duplicate CFLAGS
>
> These assignments caused CFLAGS specified on the configure line to
> appear twice in the final CFLAGS. Removing them makes the behavior
> reasonable -- USER_CFLAGS are appended at the end of CFLAGS, allowing
> the builder to override flags added by configure.ac like
> -fno-strict-aliasing.
>
> Reviewed-by: Adam Jackson <ajax at redhat.com>
>
> ---
>
>  configure.ac |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 87fb859..2b5abb4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -26,10 +26,6 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
>  LT_PREREQ([2.2])
>  LT_INIT([disable-static])
>
> -dnl Save user CFLAGS and CXXFLAGS so one can override the default ones
> -USER_CFLAGS="$CFLAGS"
> -USER_CXXFLAGS="$CXXFLAGS"
> -
>  dnl Versions for external dependencies
>  LIBDRM_REQUIRED=2.4.24
>  LIBDRM_RADEON_REQUIRED=2.4.31
>
> _______________________________________________
> mesa-commit mailing list
> mesa-commit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-commit