[Mesa-dev] [PATCH] gallium: unify transfer functions
michel at daenzer.net
Wed Oct 10 00:37:28 PDT 2012
On Mit, 2012-10-10 at 03:04 +0200, Marek Olšák wrote:
> this is actually a very small cleanup that got unexpectedly big. I
> really underestimated the size of gallium.
We used to do this sort of rework a lot in the early days of Gallium,
good thing it's settled down a bit. :)
> It's part of the plan discussed here:
> The idea is that get_transfer+transfer_map is folded into
> transfer_map, and transfer_unmap+transfer_destroy is folded into
> transfer_unmap. transfer_map must create and return the transfer
> object and transfer_unmap must destroy it. transfer_map is successful
> if the returned buffer pointer is not NULL. If transfer_map fails, the
> pointer to the transfer object remains unchanged (i.e. doesn't have to
> be NULL).
> I couldn't send the patch to mesa-dev, because it's too big. It's here:
> 103 files changed, 1204 insertions, 2014 deletions
> There are no piglit regressions on r600g, softpipe, and llvmpipe. I
> haven't tested the other drivers nor have I tested the state trackers
> not covered by piglit.
> I get that I won't get a review of the whole patch, but at least an
> ack would be appreciated. :)
Looks good to me, thanks for doing this.
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
More information about the mesa-dev