[Mesa-dev] [PATCH 1/4] st/mesa: remove useless checking in reset_cache

Brian Paul brianp at vmware.com
Wed Oct 10 09:02:37 PDT 2012


On 10/09/2012 04:48 PM, Marek Olšák wrote:
> It's always NULL here.
> ---
>   src/mesa/state_tracker/st_cb_bitmap.c |    6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_cb_bitmap.c b/src/mesa/state_tracker/st_cb_bitmap.c
> index 62e5712..e4d6c4a 100644
> --- a/src/mesa/state_tracker/st_cb_bitmap.c
> +++ b/src/mesa/state_tracker/st_cb_bitmap.c
> @@ -555,7 +555,6 @@ draw_bitmap_quad(struct gl_context *ctx, GLint x, GLint y, GLfloat z,
>   static void
>   reset_cache(struct st_context *st)
>   {
> -   struct pipe_context *pipe = st->pipe;
>      struct bitmap_cache *cache = st->bitmap.cache;
>
>      /*memset(cache->buffer, 0xff, sizeof(cache->buffer));*/
> @@ -566,11 +565,6 @@ reset_cache(struct st_context *st)
>      cache->ymin = 1000000;
>      cache->ymax = -1000000;
>
> -   if (cache->trans) {
> -      pipe->transfer_destroy(pipe, cache->trans);
> -      cache->trans = NULL;
> -   }
> -
>      assert(!cache->texture);
>
>      /* allocate a new texture */

For the series, Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list