[Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

[Jose Fonseca]

----- Original Message -----
> On Thu, Oct 11, 2012 at 8:53 PM, Matt Turner <mattst88 at gmail.com>
> wrote:
> > On Thu, Oct 11, 2012 at 2:12 PM, Dave Airlie <airlied at gmail.com>
> > wrote:
> >>> Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run
> >>> swrast.
> >>> This is not what people expect.
> >>
> >> Is it documented either way, its kinda like ifdef vs if in C, I
> >> generally for this sort of thing except ifdef behaviour.
> >>
> >> Dave.
> >
> > envvars.html says
> >
> > <li>LIBGL_ALWAYS_INDIRECT - forces an indirect rendering
> > context/connection.
> > <li>LIBGL_ALWAYS_SOFTWARE - if set, always use software rendering
> >
> > which I should update as a part of this patch.
> 
> From reading your last two mails, I think do nothing is a fine
> solution. Why change it if only 10 out 10517 hits tried to use it
> wrong,
> 
> its documented, changing it also means we have two documented
> behaviours for different releases of mesa.

I agree. I'd suggest merely make it easier to recognize when LIBGL_ALWAYS_SOFTWARE option is actived with a proheminent mensage:

  'LIBGL_ALWAYS_SOFTWARE environment set. Forcing software rendering.' 

Jose