[Mesa-dev] [PATCH] intel: Skip texsubimage fastpath for more pixel unpack state

[Eric Anholt]

Chad Versace <chad.versace at linux.intel.com> writes:

> Fixes piglit tests "unpack-teximage2d --pbo=* --format=GL_BGRA" on
> Sandybridge+.
>
> The fastpath was checking an incomplete set of pixel unpack state. This
> patch adds checks for all the fields of gl_pixelstore_attrib that affect
> 2D texture uploads.  Also, it begins permitting the case where
> GL_UNPACK_ROW_LENGTH is 0.
>
> Ideally, we would just ask a unicorn to JIT this fastpath for us in
> a way that safely handles the unpacking state. Until then, it's safer if
> only a small set of situations activate the fastpath.

> +       packing->BufferObj != ctx->Shared->NullBufferObj ||

I think this is usually _mesa_is_bufferobj(packing->BufferObj).

Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121017/6f11c70e/attachment.pgp>