[Mesa-dev] [PATCH] st/mesa: Fix source miptree level for copying data to finalized miptree.

Brian Paul brianp at vmware.com
Fri Oct 19 09:03:40 PDT 2012


On 10/19/2012 09:57 AM, Michel Dänzer wrote:
> On Fre, 2012-10-19 at 08:43 -0600, Brian Paul wrote:
>> On 10/19/2012 08:00 AM, Michel Dänzer wrote:
>>> From: Michel Dänzer<michel.daenzer at amd.com>
>>>
>>> Fixes WebGL texture mips conformance test, no piglit regressions.
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44912
>>>
>>> NOTE: This is a candidate for the stable branches.
>>>
>>> Signed-off-by: Michel Dänzer<michel.daenzer at amd.com>
>>> [...]
>>
>> LGTM.  Thanks for fixing this one.  I assume there's no piglit
>> regressions.
>
> Right, the commit message even says so. :)

Oops, missed that.

>> Reviewed-by: Brian Paul<brianp at vmware.com>
>
> Thanks! (Also to Andreas for testing)
>
>
> I posted a v2 patch which adds the assertions in all cases and hopefully
> makes the fix a little clearer. Unless you prefer v1, I'm going to push
> v2.

Looks good.

-Brian


More information about the mesa-dev mailing list