[Mesa-dev] [PATCH] i965/vs: Fix debug dumping of VS push constants.

Eric Anholt eric at anholt.net
Mon Oct 22 09:17:31 PDT 2012

Kenneth Graunke <kenneth at whitecape.org> writes:

> While copying the values into the batch space, we advance the param
> pointer.  The debug code then tries to iterate over all the uploaded
> values, starting at param...which is now the end of the uploaded data,
> rather than the start.
> This patch saves a pointer to the start of push constant space before
> it gets altered and switches the debug code to use that.
> Tested by uncommenting the code and examining the output of
> glsl-vs-clamp-1.shader_test.  Previously all values appeared to be zero.
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

It would be nice if we just always uses_new_param_layout and stopped
incrementing the pointer, but I think you're looking at this code
because you're trying to do that.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121022/bdc5adbd/attachment.pgp>

More information about the mesa-dev mailing list