[Mesa-dev] [PATCH 5/8] mesa: fix indentation in get-pick-list.sh script

Ian Romanick idr at freedesktop.org
Mon Oct 22 14:05:40 PDT 2012


On 10/22/2012 01:00 PM, Andreas Boll wrote:
> NOTE: This is a candidate for the stable branches.

The first five patches look great.  You improved my script a lot.  I'd 
suggest squashing them together before pushing.  That makes it a lot 
easier to pick over.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>   bin/get-pick-list.sh |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
> index 363bac7..7288090 100755
> --- a/bin/get-pick-list.sh
> +++ b/bin/get-pick-list.sh
> @@ -11,11 +11,11 @@ git log --reverse --grep="cherry picked from commit" origin/master..HEAD |\
>   git log --reverse --pretty=%H -i --grep='^[[:space:]]*NOTE: This is a candidate' HEAD..origin/master |\
>   while read sha
>   do
> -    # Check to see whether the patch is on the ignore list.
> +	# Check to see whether the patch is on the ignore list.
>   	if [ -f .git/cherry-ignore ] ; then
> -	    if grep -q ^$sha .git/cherry-ignore ; then
> -		continue
> -	    fi
> +		if grep -q ^$sha .git/cherry-ignore ; then
> +			continue
> +		fi
>   	fi
>
>   	# Check to see if it has already been picked over.
>



More information about the mesa-dev mailing list