[Mesa-dev] [PATCH 2/2] dispatch_sanity: print names of functions that shouldnt be in dispatch table.

[Paul Berry]

Previously we just printed the dispatch table index and the user had
to convert it to a function name.  That was a pain because when
FEATURE_remap_table is defined, the assignment of functions to
dispatch table entries is done at run time.
---
 src/mesa/main/tests/dispatch_sanity.cpp | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
index dbca581..ee53d2e 100644
--- a/src/mesa/main/tests/dispatch_sanity.cpp
+++ b/src/mesa/main/tests/dispatch_sanity.cpp
@@ -100,6 +100,13 @@ DispatchSanity_test::SetUp()
    _mesa_init_driver_functions(&driver_functions);
 }
 
+static const char *
+offset_to_proc_name_safe(unsigned offset)
+{
+   const char *name = _glapi_get_proc_name(offset);
+   return name ? name : "???";
+}
+
 static void
 validate_functions(_glapi_proc *table, const struct function *function_table)
 {
@@ -122,7 +129,8 @@ validate_functions(_glapi_proc *table, const struct function *function_table)
 
    const unsigned size = _glapi_get_dispatch_table_size();
    for (unsigned i = 0; i < size; i++) {
-      EXPECT_EQ((_glapi_proc) _mesa_generic_nop, table[i]) << "i = " << i;
+      EXPECT_EQ((_glapi_proc) _mesa_generic_nop, table[i])
+         << "i = " << i << " (" << offset_to_proc_name_safe(i) << ")";
    }
 }
 
-- 
1.7.12.4