[Mesa-dev] [PATCH 4/4] i965: Make GL_TIME_ELAPSED only track time for this context.

Kenneth Graunke kenneth at whitecape.org
Tue Oct 23 23:30:24 PDT 2012

I like this!

For the series:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

However, there's one thing you missed: since you made it emit_end_query 
for (potentially) both OQ -and- timestamp on batchbuffer end, you should 
reserve enough space for the extra PIPE_CONTROLs emitted by 

This means adding an extra (4+5)*4 = 36 bytes to BATCH_RESERVED in 
intel_batchbuffer.h, and updating the comment accordingly.

Also, a tiny nit: the comment on brw_emit_query_end() is now 
incomplete/out of date (it does more than getting an ending 


More information about the mesa-dev mailing list