[Mesa-dev] [PATCH v2] st/mesa: Fix assertions for copying texture image to finalized miptree.

Michel Dänzer michel at daenzer.net
Wed Oct 24 09:06:44 PDT 2012


On Mit, 2012-10-24 at 17:47 +0200, Andreas Boll wrote: 
> 2012/10/23 Michel Dänzer <michel at daenzer.net>:
> > From: Michel Dänzer <michel.daenzer at amd.com>
> >
> > The layer dimension of array textures is not subject to mipmap minification.
> > OTOH we were missing an assertion for the depth dimension.
> >
> > Fixes assertion failures with piglit {f,v}s-textureSize-sampler1DArrayShadow.
> > For some reason, they only resulted in piglit 'warn' results for me, not
> > failures.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56211
> >
> > NOTE: This is a candidate for the stable branches.
> >
> > Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> Tested-by: Andreas Boll <andreas.boll.dev at gmail.com>
> 
> no piglit regression on r600g (rv770), softpipe and llvmpipe
> and I can confirm that it fixes the assertion failures with piglit
> tests {f,v}s-textureSize-sampler1DArrayShadow
> 
> Thanks Michel!

Thank you guys again for the review and testing.

I've pushed v2 to master. Andreas, can you cherry-pick to the 9.0 and
8.0 branches again?


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the mesa-dev mailing list