[Mesa-dev] [PATCH 3/8] swrast: Remove the 2_3_3_REV framebuffer format

[Brian Paul]

On 10/24/2012 11:08 AM, Ian Romanick wrote:
> From: Ian Romanick<ian.d.romanick at intel.com>
>
> There is no gl_format in Mesa that corresponds to this arrangement, so I
> have a very hard time believing that this works.
>
> Signed-off-by: Ian Romanick<ian.d.romanick at intel.com>
> Cc: Brian Paul<brianp at vmware.com>
> ---
>   src/mesa/drivers/dri/swrast/swrast.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/swrast/swrast.c b/src/mesa/drivers/dri/swrast/swrast.c
> index 7596973..c608bcd 100644
> --- a/src/mesa/drivers/dri/swrast/swrast.c
> +++ b/src/mesa/drivers/dri/swrast/swrast.c
> @@ -161,10 +161,6 @@ swrastFillInModes(__DRIscreen *psp,
>       back_buffer_factor = 2;
>
>       switch (pixel_bits) {
> -    case 8:
> -	fb_format = GL_RGB;
> -	fb_type = GL_UNSIGNED_BYTE_2_3_3_REV;
> -	break;
>       case 16:
>   	fb_format = GL_RGB;
>   	fb_type = GL_UNSIGNED_SHORT_5_6_5;

Yeah, MESA_FORMAT_RGB332 would correspond to GL_UNSIGNED_BYTE_2_3_3 
but GL_UNSIGNED_BYTE_2_3_3_REV has no Mesa format.

In any case, I don't think anyone cares about 8bpp TrueColor anymore.

Reviewed-by: Brian Paul <brianp at vmware.com>