[Mesa-dev] [PATCH 8/9] dispatch_sanity test: allow functions that Mesa doesn't yet support

Ian Romanick idr at freedesktop.org
Thu Oct 25 11:17:45 PDT 2012


On 10/24/2012 02:20 PM, Jordan Justen wrote:
> For newer versions of GL, we can indicate that GL requires the
> function, but Mesa does not yet support it.
>
> To indicate a function is not yet known by Mesa, you add a dash (-)
> at the start of the name.
>
> If the function is required for the context version being tested,
> then the test will assert.

Per my comments in the next patch, I think this patch can be dropped. 
One further comment below...

>
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>   src/mesa/main/tests/dispatch_sanity.cpp |    9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
> index 40b3d8e..d5f0467 100644
> --- a/src/mesa/main/tests/dispatch_sanity.cpp
> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
> @@ -121,6 +121,15 @@ DispatchSanity_test::validate_functions()
>            ? function_table[i].offset
>            : _glapi_get_proc_offset(function_table[i].name);
>
> +      if (function_table[i].name[0] == '-') {
> +          ASSERT_EQ (false, cant_be_nop)
> +             << "Function " << (function_table[i].name + 1)
> +             << " is required by GL " << (ctx.Version / 10)
> +             << '.' << (ctx.Version % 10)
> +             << " but MESA doesn't support it.";

	ASSERT_FALSE(cant_be_nop) ...

> +          continue;
> +      }
> +
>         ASSERT_NE(-1, offset)
>            << "Function: " << function_table[i].name;
>         ASSERT_EQ(offset,
>



More information about the mesa-dev mailing list