[Mesa-dev] [PATCH 1/3] vbo: implement uploading of current attribs

[Eric Anholt]

Marek Olšák <maraeo at gmail.com> writes:

> The driver chooses which attrib should be uploaded by calling
> vbo_get_current_attrib_buffer.
>
> The reason for this is we can track which current attribs are dirty and skip
> uploading accordingly. Before, we had to upload the attribs every draw call,
> which wasn't very effective.
>
> Stats for a whole run of the Nexuiz demo2 benchmark:
>   Without the following st/mesa patch:
>   - 21099 zero-stride vertices uploaded in u_vbuf.
>   With the st/mesa patch:
>   - 2474 zero-stride vertices uploaded in vbo.

How about actual performance stats?  It seems like this might help, but
I'm always dubious of +LOC without stats.

I think there are updates to Current.Attrib that were missed in the
flagging, grepping for that: _mesa_update_color_material() calls.

Also it seems like there must be something else that needs flagging, but
I can't find it.  Isn't copy_to_current about the transition from
per-vertex varying attributes to a uniform per draw call attribute, and
unused if you're only updating the current attribute in between
beginend/drawarrays?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121029/3b033f6a/attachment.pgp>