[Mesa-dev] [PATCH] ralloc: Annotate printf functions with PRINTFLIKE(...)

Ian Romanick idr at freedesktop.org
Mon Oct 29 18:29:41 PDT 2012

On 10/29/2012 02:41 PM, Kenneth Graunke wrote:
> On 10/24/2012 01:03 PM, Ian Romanick wrote:
>> On 10/24/2012 12:15 PM, Matt Turner wrote:
>>> Catches problems such as (in the gles3 branch)
>>> glcpp-parse.y: In function '_glcpp_parser_handle_version_declaration':
>>> glcpp-parse.y:1990:39: warning: format '%lli' expects argument of type
>>>     'long long int', but argument 4 has type 'int' [-Wformat]
>>> As a side-effect, remove ralloc.c's likely/unlikely macros and just use
>>> the ones from main/compiler.h.
>> This should probably go into at least the 9.0 branch and possibly 8.0 as
>> well.
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> Considering this patch only generates additional warnings and doesn't
> actually fix anything, I don't see much point to backporting it.  On the
> flip side, I don't see any harm either.

I was just thinking we could have pre-existing bugs on the old branches 
that were already fixed on master.  *shrug*

More information about the mesa-dev mailing list