[Mesa-dev] [PATCH] draw: fix assertion failure in draw_emit_vertex_attr

[Marek Olšák]

On Tue, Oct 30, 2012 at 3:37 PM, Andreas Boll
<andreas.boll.dev at gmail.com> wrote:
> 2012/10/30 Marek Olšák <maraeo at gmail.com>:
>> This is a regression since b3921e1f53833420e0a0fd581f7417.
>>
>> The array stores VS outputs, not FS inputs.
>> Now llvmpipe can do 32 varyings too.
>>
>> NOTE: This is a candidate for the stable branches.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56552
>
> I can confirm that this patch fixes the regressed piglit test:
> ./bin/glsl-max-varyings -auto
>
> But I noticed that this test takes much longer on my system now.
>
> llvmpipe on mesa-9.1-master before b3921e1
>
> Vertical axis: Increasing numbers of varyings.
> Horizontal axis: Which of the varyings contains the color.
> GL_MAX_VARYING_FLOATS = 64
> PIGLIT: {'result': 'pass' }
>
> real    0m8.991s
> user    0m8.949s
> sys     0m0.032s
>
>
> llvmpipe on mesa-9.1-master after b3921e1 + draw fix
>
> Vertical axis: Increasing numbers of varyings.
> Horizontal axis: Which of the varyings contains the color.
> GL_MAX_VARYING_FLOATS = 128
> PIGLIT: {'result': 'pass' }
>
> real    1m1.298s
> user    1m1.160s
> sys     0m0.072s
>
>
> Could we accelerate this test somehow?

Yes, the shader compilation could be moved outside of the loop in the
draw function, but the shader would have to be rewritten.

Marek