[Mesa-dev] [PATCH 3/3] mesa: add missing return statements after recording errors

[Kenneth Graunke]

On 09/03/2012 07:13 AM, Brian Paul wrote:
> From: Brian Paul <brianp at vmware.com>
> 
> ---
>  src/mesa/main/eval.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/main/eval.c b/src/mesa/main/eval.c
> index 7709217..487c4ce 100644
> --- a/src/mesa/main/eval.c
> +++ b/src/mesa/main/eval.c
> @@ -384,6 +384,7 @@ map1(GLenum target, GLfloat u1, GLfloat u2, GLint ustride,
>     k = _mesa_evaluator_components( target );
>     if (k == 0) {
>        _mesa_error( ctx, GL_INVALID_ENUM, "glMap1(target)" );
> +      return;
>     }
>  
>     if (ustride < k) {
> @@ -473,6 +474,7 @@ map2( GLenum target, GLfloat u1, GLfloat u2, GLint ustride, GLint uorder,
>     k = _mesa_evaluator_components( target );
>     if (k==0) {
>        _mesa_error( ctx, GL_INVALID_ENUM, "glMap2(target)" );
> +      return;
>     }
>  
>     if (ustride < k) {

Wow.  Never even seen this code before :)

This patch is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>