[Mesa-dev] [PATCH] radeon/llvm: swap wrong OPCODE_IS_*_ZERO_* opcode and use

[Tom Stellard]

On Tue, Sep 04, 2012 at 04:49:25PM +0200, Vincent Lejeune wrote:
> ---
>  src/gallium/drivers/radeon/AMDGPUInstrInfo.h    | 4 ++--
>  src/gallium/drivers/radeon/R600ISelLowering.cpp | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

> diff --git a/src/gallium/drivers/radeon/AMDGPUInstrInfo.h b/src/gallium/drivers/radeon/AMDGPUInstrInfo.h
> index 2643119..a308076 100644
> --- a/src/gallium/drivers/radeon/AMDGPUInstrInfo.h
> +++ b/src/gallium/drivers/radeon/AMDGPUInstrInfo.h
> @@ -25,8 +25,8 @@
>  #define GET_INSTRINFO_ENUM
>  #include "AMDGPUGenInstrInfo.inc"
>  
> -#define OPCODE_IS_ZERO_INT 0x00000045
> -#define OPCODE_IS_NOT_ZERO_INT 0x00000042
> +#define OPCODE_IS_ZERO_INT 0x00000042
> +#define OPCODE_IS_NOT_ZERO_INT 0x00000045
>  #define OPCODE_IS_ZERO 0x00000020
>  #define OPCODE_IS_NOT_ZERO 0x00000023
>  
> diff --git a/src/gallium/drivers/radeon/R600ISelLowering.cpp b/src/gallium/drivers/radeon/R600ISelLowering.cpp
> index 66dc188..a1dcb5d 100644
> --- a/src/gallium/drivers/radeon/R600ISelLowering.cpp
> +++ b/src/gallium/drivers/radeon/R600ISelLowering.cpp
> @@ -217,7 +217,7 @@ MachineBasicBlock * R600TargetLowering::EmitInstrWithCustomInserter(
>          BuildMI(*BB, I, BB->findDebugLoc(I), TII->get(AMDGPU::PRED_X))
>                  .addReg(AMDGPU::PREDICATE_BIT)
>                  .addOperand(MI->getOperand(1))
> -                .addImm(OPCODE_IS_ZERO)
> +                .addImm(OPCODE_IS_NOT_ZERO)
>                  .addImm(0); // Flags
>        TII->addFlag(NewMI, 1, MO_FLAG_PUSH);
>        BuildMI(*BB, I, BB->findDebugLoc(I), TII->get(AMDGPU::JUMP))
> @@ -231,7 +231,7 @@ MachineBasicBlock * R600TargetLowering::EmitInstrWithCustomInserter(
>          BuildMI(*BB, I, BB->findDebugLoc(I), TII->get(AMDGPU::PRED_X))
>                .addReg(AMDGPU::PREDICATE_BIT)
>                .addOperand(MI->getOperand(1))
> -              .addImm(OPCODE_IS_ZERO_INT)
> +              .addImm(OPCODE_IS_NOT_ZERO_INT)
>                .addImm(0); // Flags
>        TII->addFlag(NewMI, 1, MO_FLAG_PUSH);
>        BuildMI(*BB, I, BB->findDebugLoc(I), TII->get(AMDGPU::JUMP))
> -- 
> 1.7.11.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev