[Mesa-dev] [PATCH] i965/fs: Fix handling of abs modifiers in copy propagation.

Kenneth Graunke kenneth at whitecape.org
Tue Sep 4 11:11:02 PDT 2012


On 09/04/2012 10:32 AM, Kenneth Graunke wrote:
> We recorded MOVs in the ACP that had abs modifiers (losing the sign of
> the original value), and then went ahead and copy propagated that into
> an expression that needed the original signed value.
> 
> NOTE: This is a candidate for stable release branches.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> I think a similar bug exists in register_coalesce()...

NAK this patch.  My analysis was rubbish, the original code seems fine.


More information about the mesa-dev mailing list