[Mesa-dev] [PATCH 2/2] intel: add ANGLE_texture_compression_dxt extension support.

Kenneth Graunke kenneth at whitecape.org
Wed Sep 5 06:59:26 PDT 2012


On 09/04/2012 10:33 AM, Eric Anholt wrote:
> Brian Paul <brianp at vmware.com> writes:
>> Most of the patch is 'FEATURE_x' changes.  I've been tempted to rip 
>> out all that stuff.
>>
>> The original idea was to make it easy for people to build smaller Mesa 
>> subsets (and the ES subset) by running the code through the 
>> preprocessor with all the FEATURE_x flags set on/off as needed.  In 
>> the past some people were really concerned about code size for static 
>> analysis and to minimize binary sizes.  I haven't heard any concerns 
>> about that in a long time.  If someone's really determined to make a 
>> tighter subset, they'd have to go above and beyond turning off 
>> FEATURE_x flags anyway.
>>
>> And now, we're building one library that supports runtime selection of 
>> full OpenGL profiles, core profiles and ES profiles.  The FEATURE 
>> stuff doesn't add any value for that and seems more trouble than it's 
>> worth.
> 
> FEATURE_* should die in a fire.

Seconded :)



More information about the mesa-dev mailing list