[Mesa-dev] [PATCH] build/glsl: Add missing extension for builtin_compiler.

[Kenneth Graunke]

On 09/06/2012 09:08 AM, Vinson Lee wrote:
> On Thu, Sep 6, 2012 at 4:19 AM, Jon TURNEY <jon.turney at dronecode.org.uk> wrote:
>> On 06/09/2012 08:08, Matt Turner wrote:
>>> On Wed, Sep 5, 2012 at 10:48 PM, Vinson Lee <vlee at freedesktop.org> wrote:
>>>> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
>>>> ---
>>>>  src/glsl/Makefile.am |    2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am
>>>> index 20639c9..f9c8671 100644
>>>> --- a/src/glsl/Makefile.am
>>>> +++ b/src/glsl/Makefile.am
>>>> @@ -93,7 +93,7 @@ BUILT_SOURCES = glsl_parser.h builtin_function.cpp
>>>>  CLEANFILES = glsl_lexer.cc glsl_parser.cc $(BUILT_SOURCES)
>>>>
>>>>  builtin_function.cpp: $(srcdir)/builtins/profiles/* $(srcdir)/builtins/ir/* $(srcdir)/builtins/glsl/* $(srcdir)/builtins/tools/generate_builtins.py $(srcdir)/builtins/tools/texture_builtins.py builtin_compiler$(EXEEXT)
>>>> -       $(AM_V_GEN) $(PYTHON2) $(PYTHON_FLAGS) $(srcdir)/builtins/tools/generate_builtins.py ./builtin_compiler > builtin_function.cpp || rm -f builtin_function.cpp
>>>> +       $(AM_V_GEN) $(PYTHON2) $(PYTHON_FLAGS) $(srcdir)/builtins/tools/generate_builtins.py ./builtin_compiler$(EXEEXT) > builtin_function.cpp || rm -f builtin_function.cpp
>>>>
>>>>  glcpp/libglcpp.la:
>>>>         cd glcpp ; $(MAKE) $(AM_MAKEFLAGS)
>>>
>>> Looks reasonable.
>>
>> Um, I would be interested to know on what platform this is necessary. (I
>> thought that generally EXEEXT is not needed for running the executable)
> 
> The MinGW build creates builtin_compiler.exe.

But on Windows, you can just run "edit", not "edit.com".  It doesn't
work without this?

I don't care either way, but as Jon mentions, it seems kind of odd.