[Mesa-dev] [PATCH] build/glsl: Add missing extension for builtin_compiler.

[Jose Fonseca]

----- Original Message -----
> On Thu, Sep 6, 2012 at 3:21 PM, Kenneth Graunke
> <kenneth at whitecape.org> wrote:
> > On 09/06/2012 09:08 AM, Vinson Lee wrote:
> >> On Thu, Sep 6, 2012 at 4:19 AM, Jon TURNEY
> >> <jon.turney at dronecode.org.uk> wrote:
> >>> On 06/09/2012 08:08, Matt Turner wrote:
> >>>> On Wed, Sep 5, 2012 at 10:48 PM, Vinson Lee
> >>>> <vlee at freedesktop.org> wrote:
> >>>>> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> >>>>> ---
> >>>>>  src/glsl/Makefile.am |    2 +-
> >>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am
> >>>>> index 20639c9..f9c8671 100644
> >>>>> --- a/src/glsl/Makefile.am
> >>>>> +++ b/src/glsl/Makefile.am
> >>>>> @@ -93,7 +93,7 @@ BUILT_SOURCES = glsl_parser.h
> >>>>> builtin_function.cpp
> >>>>>  CLEANFILES = glsl_lexer.cc glsl_parser.cc $(BUILT_SOURCES)
> >>>>>
> >>>>>  builtin_function.cpp: $(srcdir)/builtins/profiles/*
> >>>>>  $(srcdir)/builtins/ir/* $(srcdir)/builtins/glsl/*
> >>>>>  $(srcdir)/builtins/tools/generate_builtins.py
> >>>>>  $(srcdir)/builtins/tools/texture_builtins.py
> >>>>>  builtin_compiler$(EXEEXT)
> >>>>> -       $(AM_V_GEN) $(PYTHON2) $(PYTHON_FLAGS)
> >>>>> $(srcdir)/builtins/tools/generate_builtins.py
> >>>>> ./builtin_compiler > builtin_function.cpp || rm -f
> >>>>> builtin_function.cpp
> >>>>> +       $(AM_V_GEN) $(PYTHON2) $(PYTHON_FLAGS)
> >>>>> $(srcdir)/builtins/tools/generate_builtins.py
> >>>>> ./builtin_compiler$(EXEEXT) > builtin_function.cpp || rm -f
> >>>>> builtin_function.cpp
> >>>>>
> >>>>>  glcpp/libglcpp.la:
> >>>>>         cd glcpp ; $(MAKE) $(AM_MAKEFLAGS)
> >>>>
> >>>> Looks reasonable.
> >>>
> >>> Um, I would be interested to know on what platform this is
> >>> necessary. (I
> >>> thought that generally EXEEXT is not needed for running the
> >>> executable)
> >>
> >> The MinGW build creates builtin_compiler.exe.
> >
> > But on Windows, you can just run "edit", not "edit.com".  It
> > doesn't
> > work without this?
> >
> > I don't care either way, but as Jon mentions, it seems kind of odd.
> 
> This is the MinGW build on Linux and the resulting executable is run
> with Wine. It appears the executable needs to be invoked as
> "builtin_compiler.exe". "builtin_compiler" doesn't work.

I'm not entirely sure what's the goal here: mingw cross-compilation with autotools?

For the record, MinGW cross compilation works fine with SCons (where builtin_compiler is built for the host).

For MinGW or any other sort of cross compilation with autotools, the build system need to do the same. I think it's no good to rely on wine for any cross compilation, as it's not always available. 

Jose