[Mesa-dev] [PATCH 06/10] radeonsi: Handle position input parameter for pixel shaders

[Michel Dänzer]

On Fre, 2012-09-07 at 12:09 -0400, Tom Stellard wrote: 
> @@ -128,6 +129,18 @@ static void si_pipe_shader_ps(struct pipe_context *ctx, struct si_pipe_shader *s
>  			have_perspective = TRUE;
>  		if (shader->shader.input[i].centroid)
>  			have_centroid = TRUE;
> +		if (shader->shader.input[i].name == TGSI_SEMANTIC_POSITION &&
> +					shader->shader.input[i].centroid) {
> +			/* This value will be written to
> +			 * SPI_BARYC_CNTL.POS_FLOAT_LOCATION
> +			 * Possible vaules:
> +			 * 0 -> Position = pixel center (default)
> +			 * 1 -> Position = pixel centroid
> +			 * 2 -> Position = iterated sample number XXX: What does
> +			 *                                        this mean?
> +			 */
> +			fragcoord_interp_mode = 1;
> +		}

I think TGSI_SEMANTIC_POSITION shouldn't bump ninterp or enable any of
the have_* flags here.


Other than that, the series is

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer