[Mesa-dev] [PATCH v2 08/12] gl.h: add missing GL_POLYGON_OFFSET_BIAS definition

[Ian Romanick]

On 09/10/2012 10:23 AM, Imre Deak wrote:
> On Mon, 2012-09-10 at 10:07 +0300, Ian Romanick wrote:
>> On 09/10/2012 09:41 AM, Imre Deak wrote:
>>> Signed-off-by: Imre Deak <imre.deak at intel.com>
>>> ---
>>>    include/GL/gl.h |    1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/GL/gl.h b/include/GL/gl.h
>>> index e65e1bc..850fe4b 100644
>>> --- a/include/GL/gl.h
>>> +++ b/include/GL/gl.h
>>> @@ -276,6 +276,7 @@ typedef double		GLclampd;	/* double precision float in [0,1] */
>>>    #define GL_CULL_FACE_MODE			0x0B45
>>>    #define GL_FRONT_FACE				0x0B46
>>>    #define GL_POLYGON_OFFSET_FACTOR		0x8038
>>> +#define GL_POLYGON_OFFSET_BIAS			0x8039
>>
>> NAK.  There is no such enum name.  There was GL_POLYGON_OFFSET_BIAS_EXT
>> in GL_EXT_polygon_offset, but that part of the extension wasn't brought
>> into the core spec.
>
> Ok, my bad I didn't check this against the core spec.
> POLYGON_OFFSET_BIAS is part of gl_API.xml though, so should we rename it
> there to POLYGON_OFFSET_BIAS_EXT?

You are correct.  gl_API.xml is wrong... and I'm the one that made the 
error. :)  That enum should get moved from the 1.1 section to the 
EXT_polygon_offset section, and _EXT should be added to its name.

>>>    #define GL_POLYGON_OFFSET_UNITS			0x2A00
>>>    #define GL_POLYGON_OFFSET_POINT			0x2A01
>>>    #define GL_POLYGON_OFFSET_LINE			0x2A02
>>>