[Mesa-dev] [PATCH] mesa/es: Define GL_MAX_TEXTURE_MAX_ANISOTROPY_EXT enum for all GLs

[Kenneth Graunke]

On 09/11/2012 02:14 AM, Tomeu Vizoso wrote:
> instead of just for GL and ES1.
> ---
>  src/mesa/main/get.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
> index 24d2a18..e40569d 100644
> --- a/src/mesa/main/get.c
> +++ b/src/mesa/main/get.c
> @@ -536,6 +536,11 @@ static const struct value_desc values[] = {
>     /* GL_{APPLE,ARB,OES}_vertex_array_object */
>     { GL_VERTEX_ARRAY_BINDING_APPLE, ARRAY_INT(Name), NO_EXTRA },
>  
> +   /* GL_EXT_texture_filter_anisotropic */
> +   { GL_MAX_TEXTURE_MAX_ANISOTROPY_EXT,
> +     CONTEXT_FLOAT(Const.MaxTextureMaxAnisotropy),
> +     extra_EXT_texture_filter_anisotropic },
> +
>  #if FEATURE_GL || FEATURE_ES1
>     /* Enums in OpenGL and GLES1 */
>     { 0, 0, TYPE_API_MASK, API_OPENGL_BIT | API_OPENGLES_BIT | API_OPENGL_CORE_BIT, NO_EXTRA },
> @@ -685,11 +690,6 @@ static const struct value_desc values[] = {
>     /* GL_EXT_texture_lod_bias */
>     { GL_MAX_TEXTURE_LOD_BIAS_EXT, CONTEXT_FLOAT(Const.MaxTextureLodBias),
>       NO_EXTRA },
> -
> -   /* GL_EXT_texture_filter_anisotropic */
> -   { GL_MAX_TEXTURE_MAX_ANISOTROPY_EXT,
> -     CONTEXT_FLOAT(Const.MaxTextureMaxAnisotropy),
> -     extra_EXT_texture_filter_anisotropic },
>  #endif /* FEATURE_GL || FEATURE_ES1 */
>  
>  #if FEATURE_ES1
> 

This looks reasonable to me.  I don't see any evidence in the spec that
this extension couldn't apply to ES2/ES3, and Mesa's extensions.c does
currently say it's supported under ES2.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>