[Mesa-dev] [PATCH 1/3] mesa: do internal format error checking for glTexStorage()

[Brian Paul]

On 09/12/2012 10:34 AM, Andreas Boll wrote:
> This commit introduces a regression.
> Now the piglit test spec/ARB_texture_storage/texture-storage fails on
> r600g, llvmpipe and softpipe
>
> 2e4fc54977977e674ee77294e6632a24e594d17f is the first bad commit
> commit 2e4fc54977977e674ee77294e6632a24e594d17f
> Author: Brian Paul<brianp at vmware.com>
> Date:   Sat Sep 8 09:27:46 2012 -0600
>
>      mesa: do internal format error checking for glTexStorage()
>
>      Turns out we weren't doing any format checking before.  Now check
>      the internal format and, in particular, make sure that unsized internal
>      formats aren't accepted.
>
>      Note: This is a candidate for the stable branches.
>
> Steps to reproduce:
>
> $ ./bin/arb_texture_storage-texture-storage -auto
>
> texture-storage: bad width: 0, should be 64
> texture-storage: bad width: 0, should be 64
> texture-storage: bad width: 0, should be 64
> texture-storage: GL_TEXTURE_1D GL_TEXTURE_IMMUTABLE_FORMAT query returned false
> texture-storage: GL_TEXTURE_2D GL_TEXTURE_IMMUTABLE_FORMAT query returned false
> texture-storage: GL_TEXTURE_3D GL_TEXTURE_IMMUTABLE_FORMAT query returned false
> texture-storage: level 0: bad width: 0, should be 128
> PIGLIT: {'result': 'fail' }

Have you updated your piglit tree recently?  I made some changes to 
the test too.

-Brian