[Mesa-dev] [PATCH v2 00/45] Remove many of the FEATURE_* defines.

[Brian Paul]

On 09/14/2012 04:30 AM, Oliver McFadden wrote:
> On Thu, Sep 13, 2012 at 03:00:48PM -0600, Brian Paul wrote:
>> On 09/13/2012 02:18 AM, Oliver McFadden wrote:
>>> Hi,
>>>
>>> As requested here is the second version of the patch series which removes almost
>>> all of the FEATURE_* defines, typically used to enable or disable some GL
>>> feature or extension.  I have again ran this series through automatic git-bisect
>>> with a script to compile Mesa.  The series is bisect-clean with the following
>>> configuration:
>>>
>>> $ ./autogen.sh --prefix=/usr --without-gallium-drivers --with-dri-drivers=i965,swrast --enable-gles1 --enable-gles2
>>>
>>> I expect it's also bisect-clean with all other configurations, but if you wish
>>> for further testing with Gallium and more DRI drivers then I need to install and
>>> setup some other packages.
>>>
>>> mfeatures.h still exists and we still have FEATURE_GL, FEATURE_ES, FEATURE_ES1,
>>> FEATURE_ES2, and FEATURE_remap_table. However, they are only used where a
>>> ctx->API check would be missing.  I did not touch FEATURE_remap_table because
>>> there is some Python code involved there and that's not my forte.
>>>
>>> The features are removed in roughly the order they were specified in
>>> mfeatures.h; I took some liberties where it would make things easier to do
>>> out-of-order operations.
>>>
>>>     124 files changed, 9 insertions(+), 1631 deletions(-)
>>>
>>> Hopefully my somewhat cold-addled brain hasn't fscked up and made any mistakes.
>>> You may wish to pay special attention to patch #46, but I believe it's fine.
>>
>> Thanks.
>>
>> I reviewed patches 1-20 and they look good.  I'll try to get to the
>> rest soon.  You can commit these yourself, right?
>
> I can commit myself, yes.  I will await your review on the remaining
> patches in the series.

OK, I've reviewed the rest.  Looks good.  Thanks!

Reviewed-by: Brian Paul <brianp at vmware.com>