[Mesa-dev] [PATCH 1/2] build: Don't cross-compile GLSL builtin compiler

[Thierry Reding]

On Fri, Sep 14, 2012 at 08:40:48AM -0700, Matt Turner wrote:
> On Fri, Sep 14, 2012 at 8:37 AM, Matt Turner <mattst88 at gmail.com> wrote:
> > On Fri, Sep 14, 2012 at 12:22 AM, Thierry Reding
> > <thierry.reding at avionic-design.de> wrote:
> >> The builtin_compiler binary is used during the build process to generate
> >> code for the builtin GLSL functions. Since this binary needs to be run
> >> on the build host, it must not be cross-compiled.
> >>
> >> This patch fixes the build system to compile a second version of the
> >> source files and the builtin_compiler binary itself for the build
> >> system. It does so by defining the CC_FOR_BUILD and CXX_FOR_BUILD
> >> variables, which are searched for by the configure script and point to
> >> the location of native C and C++ compilers.
> >> ---
> >
> > I wish you'd sent this to the list a bit more promptly since the last
> > update to bug 44618 eight months ago. As it is now, I've got a large
> > (100) patch series in progress that touches these Makefile.am's.
> >
> > Overall, it looks pretty good. I'm very glad to learn about the AX_
> > macros. I feel much better adding those to Mesa's build system than
> > macros like we have now (see MESA_PIC_FLAGS).
> >
> > I'd like it if this could be made a patch on top of my
> > automake-gallium series,
> > http://cgit.freedesktop.org/~mattst88/mesa/log/?h=automake-gallium
> 
> One other question: do you want to be able to do a cross-compile from
> git? If not, we could add builtin_function.cpp to the distribution
> list and have it provided in Mesa tarballs. That would remove the need
> for this, at the cost of not being able to cross compile sources
> checked out of git.

I want to be able to do both. Also as far as I remember not having to
ship builtin_function.cpp in the tarballs was the reason why
builtin_compiler was added in the first place. So I really want this to
be fixed properly. Heh, this sounds as if I was the only person around
that wants to cross-compile Mesa, but I suspect that's not the case. =)

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120914/017d9396/attachment.pgp>