[Mesa-dev] [PATCH] meta: Refactor handling of GL_MULTISAMPLE.

[Kenneth Graunke]

On 09/13/2012 10:50 AM, Paul Berry wrote:
> In commit 055093e (meta: remove call to _meta_in_progress(), fix
> multisample enable/disable), we created a meta_set_enable() function
> that could be used by meta ops to enable and disable GL_MULTISAMPLE
> even when the GLES API was in use (the GLES API doesn't support
> GL_MULTISAMPLE; it behaves as if it is always enabled).  This created
> some unfortunate code duplication between meta_set_enable() and the
> existing _mesa_set_enable() function.
> 
> This patch eliminates the duplication by creating a
> _mesa_set_multisample() function, which is used by both meta ops and
> _mesa_set_enable() to enable/disable GL_MULTISAMPLE.
> ---
>  src/mesa/drivers/common/meta.c | 33 ++-------------------------------
>  src/mesa/main/enable.c         | 24 +++++++++++++++++++-----
>  src/mesa/main/enable.h         |  4 ++++
>  3 files changed, 25 insertions(+), 36 deletions(-)

looks fine to me.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>