[Mesa-dev] [PATCH 1/4] mesa/dxtn: make function pointers static

[Kenneth Graunke]

On 09/14/2012 08:18 PM, Dave Airlie wrote:
> These aren't used outside thie file from what I can see.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/mesa/main/texcompress_s3tc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/mesa/main/texcompress_s3tc.c b/src/mesa/main/texcompress_s3tc.c
> index 8736e20..b5d7d3b 100644
> --- a/src/mesa/main/texcompress_s3tc.c
> +++ b/src/mesa/main/texcompress_s3tc.c
> @@ -91,10 +91,10 @@ nonlinear_to_linear(GLubyte cs8)
>  
>  typedef void (*dxtFetchTexelFuncExt)( GLint srcRowstride, GLubyte *pixdata, GLint col, GLint row, GLvoid *texelOut );
>  
> -dxtFetchTexelFuncExt fetch_ext_rgb_dxt1 = NULL;
> -dxtFetchTexelFuncExt fetch_ext_rgba_dxt1 = NULL;
> -dxtFetchTexelFuncExt fetch_ext_rgba_dxt3 = NULL;
> -dxtFetchTexelFuncExt fetch_ext_rgba_dxt5 = NULL;
> +static dxtFetchTexelFuncExt fetch_ext_rgb_dxt1 = NULL;
> +static dxtFetchTexelFuncExt fetch_ext_rgba_dxt1 = NULL;
> +static dxtFetchTexelFuncExt fetch_ext_rgba_dxt3 = NULL;
> +static dxtFetchTexelFuncExt fetch_ext_rgba_dxt5 = NULL;
>  
>  typedef void (*dxtCompressTexFuncExt)(GLint srccomps, GLint width,
>                                        GLint height, const GLubyte *srcPixData,

"It compiles, ship it!" :D

More seriously, cleaning this up is a good idea.  If it compiles, it
ought to work.

For the series:
Acked-by: Kenneth Graunke <kenneth at whitecape.org>