[Mesa-dev] [PATCH] meta: Don't _mesa_set_enable() invalid targets in ES 1.

[Kenneth Graunke]

On 09/14/2012 11:23 PM, Ian Romanick wrote:
> On 09/14/2012 01:01 PM, Kenneth Graunke wrote:
>> GL_TEXTURE_1D, GL_TEXTURE_RECTANGLE, and GL_TEXTURE_GEN_* don't exist in
>> ES 1 contexts, so any meta ops that used _mesa_meta_begin with
>> MESA_META_TEXTURE would trigger GL errors.  One such operation is
>> _mesa_meta_Clear().
>>
>> Fixes the ES1 conformance test miplin.c, which was regressed by commit
>> 08be1d288f216232d3974f5997b266a8dd720928.
> 
> There is, however, GL_TEXTURE_GEN_STR_OES.  In ES1 we should twiddle
> that instead.  It's part of GL_OES_texture_cube_map, which I don't think
> is supported by all ES1 drivers.

Oh, good call.  I've done that in v3.

> It almost seems like we want separate _mesa_meta_begin functions for
> each API.  It's getting quite divergent. :(

I hear you.  The texturing part is very divergent.  A few other parts
diverge as well...but I still think the majority of it is shared.