[Mesa-dev] [PATCH 16/19] mesa: Don't set uniform dispatch pointers for many things in ES2 or core

[Eric Anholt]

Ian Romanick <idr at freedesktop.org> writes:

> On 09/08/2012 12:08 AM, Eric Anholt wrote:
>> Ian Romanick <idr at freedesktop.org> writes:
>>
>>> From: Ian Romanick <ian.d.romanick at intel.com>
>>>
>>> NOTE: This is a candidate for the 9.0 branch
>>>
>>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>>
>> I've reviewed up to this point, with reference to the gles3 spec to see
>> if anything got missed there.  I noted that a bunch of things seem to
>> ignore GLES1, but maybe you either didn't care (valid), or something
>> prevented those dispatch init functions from being entered at all in
>> that case.
>>
>> I haven't reviewed the unit test -- it wasn't clear to me where the list
>> of functions came from and whether they should be changed when new
>> extensions are added.
>
> Yes.  I'll add the following to the commit log.  Does that clarify enough?
>
>      The list of expected functions originally came from the functions 
> set by
>      api_exec_es2.c.  This file no longer exists in Mesa (but api_exec_es1.c
>      is still generated).  It was the generated file that configured the
>      dispatch table for ES2 contexts.  This test verifies that all of the
>      functions set by the old api_exec_es2.c (with the recent addition 
> of VAO
>      functions) are set in the dispatch table and everything else is a NOP.
>
>      When adding ES2 (or ES3) extensions that add new functions, this test
>      will need to be modified to expect dispatch functions for the new
>      extension functions.

The instructions to the developer for maintaining the unit test should
actually go into the test case -- somebody's going to add some extension
to ES2, you're going to complain that your unit test is failing now, and
they're going to say "WTF?  But my changes were correct!"

(I generally dislike this kind of test, that will fail for valid changes
to the code without updates to the test)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120919/491e520c/attachment.pgp>