[Mesa-dev] [PATCH] i965: Remove brw_set_predicate_inverse(p, true) from scratch offset code

Kenneth Graunke kenneth at whitecape.org
Thu Sep 20 16:59:08 PDT 2012


Given that it exists between a push/pop of instruction state, this call
can only affect the MOV or ADD instruction generated just below it.
Neither of those instructions are predicated, so it makes no sense to
ask for the inverse predicate.

This fixes grumblings from the simulator debugger, which was
complaining about an invalid predicate.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Cc: Paul Berry <stereotype441 at gmail.com>
Cc: Eric Anholt <eric at anholt.net>
---
 src/mesa/drivers/dri/i965/brw_vec4_emit.cpp | 1 -
 1 file changed, 1 deletion(-)

Zero piglit impact.  Paul and I have no idea why this is here.

diff --git a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
index 6417fdb..27758ab 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
@@ -521,7 +521,6 @@ vec4_visitor::generate_oword_dual_block_offsets(struct brw_reg m1,
 
    brw_MOV(p, m1_0, index_0);
 
-   brw_set_predicate_inverse(p, true);
    if (index.file == BRW_IMMEDIATE_VALUE) {
       index_4.dw1.ud += second_vertex_offset;
       brw_MOV(p, m1_4, index_4);
-- 
1.7.11.4



More information about the mesa-dev mailing list