[Mesa-dev] [PATCH] i965: Remove brw_set_predicate_inverse(p, true) from scratch offset code

Eric Anholt eric at anholt.net
Fri Sep 21 00:43:48 PDT 2012


Kenneth Graunke <kenneth at whitecape.org> writes:

> Given that it exists between a push/pop of instruction state, this call
> can only affect the MOV or ADD instruction generated just below it.
> Neither of those instructions are predicated, so it makes no sense to
> ask for the inverse predicate.
>
> This fixes grumblings from the simulator debugger, which was
> complaining about an invalid predicate.

I'm not sure what caused this code to exist.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120921/ffc8b398/attachment.pgp>


More information about the mesa-dev mailing list