[Mesa-dev] [PATCH 3/3] pipe-loader: Remove a few debug_printfs

[Francisco Jerez]

Tom Stellard <tom at stellard.net> writes:

> From: Tom Stellard <thomas.stellard at amd.com>
>
> On debug builds these were always being printed.
> ---
>
> Are these printfs useful to anyone?  Should they be controlled with an
> ENV variable instead?
>
Not much I guess... Reviewed-by: Francisco Jerez <currojerez at riseup.net>

>  src/gallium/auxiliary/pipe-loader/pipe_loader.c     | 1 -
>  src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 3 ---
>  2 files changed, 4 deletions(-)
>
> diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader.c b/src/gallium/auxiliary/pipe-loader/pipe_loader.c
> index 6a10ac3..b1d9285 100644
> --- a/src/gallium/auxiliary/pipe-loader/pipe_loader.c
> +++ b/src/gallium/auxiliary/pipe-loader/pipe_loader.c
> @@ -92,7 +92,6 @@ pipe_loader_find_module(struct pipe_loader_device *dev,
>        if (ret > 0 && ret < sizeof(path)) {
>           lib = util_dl_open(path);
>           if (lib) {
> -            debug_printf("loaded %s\n", path);
>              return lib;
>           }
>        }
> diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> index 64bd921..6dedc41 100644
> --- a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> +++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> @@ -96,7 +96,6 @@ find_drm_pci_id(struct pipe_loader_drm_device *ddev)
>     if (udev)
>        udev_unref(udev);
>  
> -   debug_printf("pci id for fd %d not found\n", ddev->fd);
>     return FALSE;
>  }
>  
> @@ -126,8 +125,6 @@ find_drm_driver_name(struct pipe_loader_drm_device *ddev)
>     return FALSE;
>  
>    found:
> -   debug_printf("driver for %04x:%04x: %s\n", dev->u.pci.vendor_id,
> -                dev->u.pci.chip_id, dev->driver_name);
>     return TRUE;
>  }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120921/d07a9390/attachment.pgp>