[Mesa-dev] [PATCH] svga: Remove wierd code which forces non-sRGB formats.

John Kåre Alsaker john.kare.alsaker at gmail.com
Mon Sep 24 22:09:51 PDT 2012


On Mon, Sep 24, 2012 at 5:22 PM, Brian Paul <brianp at vmware.com> wrote:

> On 09/23/2012 05:44 AM, John Kåre Alsaker wrote:
>
>> ---
>>   src/gallium/drivers/svga/svga_resource_texture.c | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/src/gallium/drivers/svga/svga_resource_texture.c
>> b/src/gallium/drivers/svga/svga_resource_texture.c
>> index 9830e79..97ec7ee 100644
>> --- a/src/gallium/drivers/svga/svga_resource_texture.c
>> +++ b/src/gallium/drivers/svga/svga_resource_texture.c
>> @@ -540,14 +540,6 @@ svga_texture_from_handle(struct pipe_screen *screen,
>>      pipe_reference_init(&tex->b.b.reference, 1);
>>      tex->b.b.screen = screen;
>>
>> -   if (format == SVGA3D_X8R8G8B8)
>> -      tex->b.b.format = PIPE_FORMAT_B8G8R8X8_UNORM;
>> -   else if (format == SVGA3D_A8R8G8B8)
>> -      tex->b.b.format = PIPE_FORMAT_B8G8R8A8_UNORM;
>> -   else {
>> -      /* ?? */
>> -   }
>> -
>>      SVGA_DBG(DEBUG_DMA, "wrap surface sid %p\n", srf);
>>
>>      tex->key.cachable = 0;
>>
>
> Yeah, I don't know what that's all about either.  Have you done a piglit
> run with this change to check for regressions?

Piglit doesn't pass the sanity tests with Mesa master. Are there any tests
for shared handles in there?


>
>
> -Brian
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120925/13ea398c/attachment.html>


More information about the mesa-dev mailing list