[Mesa-dev] Mesa (master): intel: Fix segfault in intel_texsubimage_tiled_memcpy

[Chad Versace]

On 09/27/2012 09:49 AM, Eric Anholt wrote:
> Chad Versace <chadversary at kemper.freedesktop.org> writes:
> 
>> Module: Mesa
>> Branch: master
>> Commit: b1d0fe022dc4826dadce014ab8fe062a82f75a16
>> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b1d0fe022dc4826dadce014ab8fe062a82f75a16
>>
>> Author: Chad Versace <chad.versace at linux.intel.com>
>> Date:   Wed Sep 26 11:05:12 2012 -0700
>>
>> intel: Fix segfault in intel_texsubimage_tiled_memcpy
>>
>> The function segfaulted when a game called glTexSubImage2D on a texture
>> with internalformat/format/type = GL_SLUMINANCE8/GL_BGRA/GL_UNSIGNED_BYTE.
>>
>> The function only supports MESA_FORMAT_ARGB8888 and returns early if it
>> detects an unsupported format. Clearly, its detection condition was
>> insufficient. This patch fixes it to explicity check for
>> MESA_FORMAT_ARGB8888.
>>
>> Note: This is a candidate for the 9.0 branch (fixes 413c491).
>> Reviewed-and-tested-by: Kenneth Graunke <kenneth at whitecape.org>
>> Acked-by: Paul Berry <stereotype441 at gmail.com>
>> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
> 
> You need to still test format/type, because that's the incoming format
> (e.g. GL_RGBA/GL_FLOAT) that you're trying to memcpy.

Gah! When will I stop thrashing on this patch?!?